-
Notifications
You must be signed in to change notification settings - Fork 15
Fix permissions issues to allow incubator project to run on Linux. #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bfdf080 to
3d711bf
Compare
caribic/src/start.rs
Outdated
| verbose("✅ Osmosis configuration files copied successfully"); | ||
| remove_previous_chain_data()?; | ||
| // This should not be required as each time it's restarted it wipes the .osmosisd-local data | ||
| // remove_previous_chain_data()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabianbormann this cleanup doesn't seem to be necessary. You can check the README.md in the localosmosis folder.
Can you remember any other reasons why this might be required?
make localnet-init
The command:
- Builds a local docker image with the latest changes
- Cleans the `$HOME/.osmosisd-local` folderThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok makes sense. It's just a re-write of the bash script. I assume we can just remove it ;)
788e292 to
2d1117b
Compare
…active (might need to enter password)
| @STATE="" docker compose -f tests/localosmosis/docker-compose.yml down | ||
|
|
||
| localnet-clean: | ||
| sudo rm -rf $(HOME)/.osmosisd-local/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabianbormann just a gotcha for you to know. following the pattern of "manually overriding files requiring changes that have been downloaded" I've replaced this localnet.mk files and fixed the "clean" command here to make it to work for latest osmosis. Just a heads up in case something breaks later ....
Docker filesystem management behaves differently on linux and macos. Non-existing folders, when mounted are created as
rooton linux but as current user on macos. This screws things up when stopping and/or cleaning up resources on linux, preventing the caribic script (which is run as current user) from working and incurring in permission denied when trying to deleterootresources.For this reason:
docker compose upis calleduserproperty specified (and defaulted to root)idandgidand passes them to the composeAlong with that, an additional change is rolling back the version of osmosis, as latest doesn't seem to be building on ubuntu.EDIT: it now works with latest osmosis. but it requires both cosmos and osmosis to run as root. so a
sudo rm -frof the~/.osmosisd-localfolder is required. Not really time or willingness to debug osmosis code to make it to work in non-sudo user (within container).